Bug 274416 – AX: must call WTF::switchOn on a copy of AXPropertyValueVariant

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Dominic Mazzoni]

WTF::switchOn takes an rvalue reference (&&) so if we 

In https://bugs.webkit.org/show_bug.cgi?id=273959 I changed a call to WTF::switchOn to avoid an extra copy. For some types it was resulting in moving the type away from the property map. Many isolated tree tests failed as a result.

Let's revert this to fix things, but it'd be nice to figure out a solution that's less fragile and doesn't require a copy just to access a value from the property map.

[Radar WebKit Bug Importer]

<rdar://problem/128416654>

[Dominic Mazzoni]

Created attachment 471453 [details]
Patch

[Tyler Wilcock]

Comment on attachment 471453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471453&action=review

r+ with commit message fixed

> COMMIT_MESSAGE:7
> +WTF::switchOn takes an rvalue reference (&&) so if we

Seems like this sentence is missing some words :)

[Tyler Wilcock]

> but it'd be nice to figure out a solution that's less fragile and doesn't require a copy just to access a value from the property map.
Indeed!

[Dominic Mazzoni]

Created attachment 471456 [details]
Patch

[EWS]

Committed 279028@main (8764515d00e9): <https://commits.webkit.org/279028@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471456 [details].