Bug 274377 - [Win] Update intrinsic device scale factor dynamically
Summary: [Win] Update intrinsic device scale factor dynamically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-19 20:58 PDT by Kohei Asano
Modified: 2024-06-14 00:58 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kohei Asano 2024-05-19 20:58:49 PDT 
Rendering with device scale factor for high DPI, https://bugs.webkit.org/show_bug.cgi?id=196339, requires re-scaling on dynamic device scale factor changes, e.g. moving a window between different displays. The appropriate winapi message to do this is WM_DPICHANGED, that MainWindow handles on https://github.com/WebKit/WebKit/blob/d48be59b226a3da86b16e3948e08db42c6637263/Tools/MiniBrowser/win/MainWindow.cpp#L392. But it couldn't be caught on WebView. We need to propagate WM_DPICHANGED from MainWindow to WebView.
Comment 1 Radar WebKit Bug Importer 2024-05-26 20:59:13 PDT 
<rdar://problem/128777848>
Comment 2 Kohei Asano 2024-06-13 20:46:00 PDT 
We noticed it's not necessary to propagate WM_DPICHANGED, we can do on WM_SIZE instead. I renamed title.
Comment 3 Kohei Asano 2024-06-14 00:37:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29810
Comment 4 EWS 2024-06-14 00:58:07 PDT 
Committed 280003@main (50c1741732a3): <https://commits.webkit.org/280003@main>

Reviewed commits have been landed. Closing PR #29810 and removing active labels.