Bug 274321 - [JSC] MacroAssemblerARM64E emits BLRAAZ, BLRABZ instead of BRAAZ, BRABZ
Summary: [JSC] MacroAssemblerARM64E emits BLRAAZ, BLRABZ instead of BRAAZ, BRABZ
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-17 10:36 PDT by Marcus Plutowski
Modified: 2024-05-17 13:59 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Plutowski 2024-05-17 10:36:01 PDT 
If you call m_assembler.braaz, it has the same effect as calling m_assembler.blraaz, which is incorrect as it would clobber lr when we don't expect it.
We don't use these instructions so this has been able to fly under the radar thus far.
Comment 1 Marcus Plutowski 2024-05-17 10:46:09 PDT 
rdar://128282890
Comment 2 Marcus Plutowski 2024-05-17 10:48:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28718
Comment 3 EWS 2024-05-17 13:59:51 PDT 
Committed 278924@main (924f61209bb0): <https://commits.webkit.org/278924@main>

Reviewed commits have been landed. Closing PR #28718 and removing active labels.