WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
274321
[JSC] MacroAssemblerARM64E emits BLRAAZ, BLRABZ instead of BRAAZ, BRABZ
https://bugs.webkit.org/show_bug.cgi?id=274321
Summary
[JSC] MacroAssemblerARM64E emits BLRAAZ, BLRABZ instead of BRAAZ, BRABZ
Marcus Plutowski
Reported
2024-05-17 10:36:01 PDT
If you call m_assembler.braaz, it has the same effect as calling m_assembler.blraaz, which is incorrect as it would clobber lr when we don't expect it. We don't use these instructions so this has been able to fly under the radar thus far.
Attachments
Add attachment
proposed patch, testcase, etc.
Marcus Plutowski
Comment 1
2024-05-17 10:46:09 PDT
rdar://128282890
Marcus Plutowski
Comment 2
2024-05-17 10:48:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/28718
EWS
Comment 3
2024-05-17 13:59:51 PDT
Committed
278924@main
(924f61209bb0): <
https://commits.webkit.org/278924@main
> Reviewed commits have been landed. Closing PR #28718 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug