Bug 274297 – Stop using `const char*` in string concatenations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Stop using `const char*` in string concatenations, to encourage the use of ASCIILiteral and std::span.

[Chris Dumez]

Pull request: https://github.com/WebKit/WebKit/pull/28707

[EWS]

Committed 278972@main (1cf337e0a50a): <https://commits.webkit.org/278972@main>

Reviewed commits have been landed. Closing PR #28707 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/128366439>

[Diego Pino]

GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 fails with the following error:

https://build.webkit.org/#/builders/30/builds/8960

(this bot builds with libwebrtc)

```
../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:121:91:   required from here
WTF/Headers/wtf/text/StringConcatenate.h:534:38: error: invalid use of incomplete type ‘class WTF::StringTypeAdapter<const char*, void>’
  534 |     return tryMakeStringFromAdapters(StringTypeAdapter<StringTypes>(strings)...);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from WTF/Headers/wtf/text/IntegerToStringConversion.h:27,
                 from WTF/Headers/wtf/text/WTFString.h:27,
                 from ../../../Source/WebCore/dom/Exception.h:30,
                 from ../../../Source/WebCore/dom/ExceptionOr.h:29,
                 from ../../../Source/WebCore/platform/mediastream/RTCDTMFSenderBackend.h:29,
                 from ../../../Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.h:30,
                 from ../../../Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.cpp:27,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-74.cpp:1:
WTF/Headers/wtf/Forward.h:106:43: note: declaration of ‘class WTF::StringTypeAdapter<const char*, void>’
  106 | template<typename, typename = void> class StringTypeAdapter;
      |                                           ^~~~~~~~~~~~~~~~~
```

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/28830

[EWS]

Committed 279038@main (d1b1d17c730c): <https://commits.webkit.org/279038@main>

Reviewed commits have been landed. Closing PR #28830 and removing active labels.