Bug 274256 - [WPE][GTK] Enable fatal criticals in MiniBrowser
Summary: [WPE][GTK] Enable fatal criticals in MiniBrowser
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-16 06:23 PDT by Michael Catanzaro
Modified: 2024-05-17 06:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2024-05-16 06:23:01 PDT 
Critical warnings should only be used to indicate programmer error. By default, they are "soft assertions" that allow program execution to continue even though we know the process is no longer operating correctly because a bug has occurred. This is a bad default. Let's crash instead, to make it easier to debug the problem, encourage bug reports, and downgrade any code execution issues into denial of service.

We cannot make this decision for applications that use WebKit, but we can do it for MiniBrowser.
Comment 1 Michael Catanzaro 2024-05-16 06:25:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28652