Bug 27423 - Remove some outdated S60 platform specific code
Summary: Remove some outdated S60 platform specific code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-19 12:35 PDT by Laszlo Gombos
Modified: 2009-07-20 02:50 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch ! (1.59 KB, patch)
2009-07-19 12:43 PDT, Laszlo Gombos 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-07-19 12:35:42 PDT 
The definition of PLATFORM(S60) is ambiguous; S60 should not be defined for the sole reason of __SYMBIAN32__ being defined. 

The PLATFORM(S60) guard is not used in the source tree, so to avoid further confusion I would propose to remove the PLATFROM(S60) definition and use PLATFORM(SYMBIAN) instead.

I confirmed that this change has no impact on the current Symbian port of QtWebKit.
Comment 1 Laszlo Gombos 2009-07-19 12:43:26 PDT 
Created attachment 33049 [details]
Proposed patch !

Also removed WTF_USE_SYMBIAN_UNICODE, it is no longer used.
Comment 2 Simon Hausmann 2009-07-20 02:50:54 PDT 
Landed in r46115