Bug 27408 - [V8] Move event listener methods from V8Proxy to V8EventListenerList
Summary: [V8] Move event listener methods from V8Proxy to V8EventListenerList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-18 01:13 PDT by Adam Barth
Modified: 2009-07-18 08:05 PDT (History)
1 user (show)

See Also:

Attachments
patch (9.52 KB, patch)
2009-07-18 01:39 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
patch (10.92 KB, patch)
2009-07-18 01:45 PDT, Adam Barth 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-18 01:13:32 PDT 
These methods really belong in one place.  Duplicated code sucks.
Comment 1 Adam Barth 2009-07-18 01:39:54 PDT 
Created attachment 33017 [details]
patch
Comment 2 Adam Barth 2009-07-18 01:45:39 PDT 
Created attachment 33018 [details]
patch
Comment 3 Adam Barth 2009-07-18 08:05:20 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8EventListenerList.cpp
	M	WebCore/bindings/v8/V8EventListenerList.h
	M	WebCore/bindings/v8/V8ObjectEventListener.cpp
	M	WebCore/bindings/v8/V8Proxy.cpp
	M	WebCore/bindings/v8/V8Proxy.h
Committed r46091
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8Proxy.h
	M	WebCore/bindings/v8/V8ObjectEventListener.cpp
	M	WebCore/bindings/v8/V8Proxy.cpp
	M	WebCore/bindings/v8/V8EventListenerList.h
	M	WebCore/bindings/v8/V8EventListenerList.cpp
r46091 = 93b96c980acbb736a206f185a1e4d85be139a0f5 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46091