Bug 27407 - [V8] Revert incomplete patch
Summary: [V8] Revert incomplete patch
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
Depends on:
Reported: 2009-07-18 00:29 PDT by Jeremy Orlow
Modified: 2009-07-20 09:55 PDT (History)
3 users (show)

See Also:

v1 (40.35 KB, patch)
2009-07-18 00:31 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
now with changelog! (42.43 KB, patch)
2009-07-18 00:36 PDT, Jeremy Orlow
abarth: review+
Details | Formatted Diff | Diff
patch, with missing file added (47.45 KB, patch)
2009-07-20 09:39 PDT, Jens Alfke
levin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-07-18 00:29:53 PDT
Revert https://bugs.webkit.org/show_bug.cgi?id=27383

It's missing a file and we want the canaries to be green over the weekend.
Comment 1 Jeremy Orlow 2009-07-18 00:31:20 PDT
Created attachment 33012 [details]

Revert Jens' patch.
Comment 2 Jeremy Orlow 2009-07-18 00:36:08 PDT
Created attachment 33013 [details]
now with changelog!

add a change log
Comment 3 Adam Barth 2009-07-18 00:38:26 PDT
Comment on attachment 33013 [details]
now with changelog!

jorlow certifies that this is a revert of a previous patch.  I apply the rubber stamp.
Comment 4 David Levin 2009-07-19 20:38:13 PDT
Committed as http://trac.webkit.org/changeset/46087

Please resolve the bug after committing the patch :)
Comment 5 Jens Alfke 2009-07-20 09:39:42 PDT
Created attachment 33090 [details]
patch, with missing file added

Added the missing WebCore/bindings/v8/custom/V8DataGridColumnListCustom.cpp; sorry about that.
This patch is up to date with the current r46125.
Comment 6 Jeremy Orlow 2009-07-20 09:45:49 PDT
Comment on attachment 33090 [details]
patch, with missing file added

I don't have review rights.  I think it's best for everyone if you leave off the requestee since really any reviewer could r+ this for you.
Comment 7 David Levin 2009-07-20 09:55:25 PDT
Comment on attachment 33090 [details]
patch, with missing file added

The patch is about fixing bug 27383, so it should be added to that bug.  (Plus you'd want to re-open any bug that has a new patch on it and clear the r+ from any old patches.)

*Also* in WebCore/bindings/v8/V8DataGridDataSource.cpp, this is missing a "//":  #endif ENABLE(DATAGRID)