Bug 27406 – Minor FrameLoader.cpp cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Adam Barth]

I was just looking at this code and it could be slightly better.

[Adam Barth]

Created attachment 33011 [details]
patch

[Jan Alonzo]

Comment on attachment 33011 [details]
patch

r=me.

[Adam Barth]

Sending        WebCore/ChangeLog
Sending        WebCore/loader/FrameLoader.cpp
Transmitting file data ..
Committed revision 46088.
http://trac.webkit.org/changeset/46088

[Darin Adler]

Comment on attachment 33011 [details]
patch

I believe sizeof("xxxxxxxxx") will always return the size of a pointer.

[Adam Barth]

Sending        WebCore/ChangeLog
Sending        WebCore/loader/FrameLoader.cpp
Transmitting file data ..
Committed revision 46094.
http://trac.webkit.org/changeset/46094

[Adam Barth]

(In reply to comment #4)
> (From update of attachment 33011 [details])
> I believe sizeof("xxxxxxxxx") will always return the size of a pointer.

I'll write a reduced test case, but the javascriptURL tests pass.

[Adam Barth]

abarth@zenque:~/tmp/sizeof$ cat main.c 
#include <stdio.h>
#include <string.h>

int main(void) {
  printf("%d\n", sizeof("A long string that has many bytes") - 1);
  printf("%d\n", strlen("A long string that has many bytes"));
  return 0;
}
abarth@zenque:~/tmp/sizeof$ gcc main.c 
abarth@zenque:~/tmp/sizeof$ ./a.out 
33
33