Bug 27404 - bugzilla-tool does not understand nested SVN repos
Summary: bugzilla-tool does not understand nested SVN repos
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 28925 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-07-17 19:28 PDT by Adam Barth
Modified: 2010-03-22 11:45 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.82 KB, patch)
2009-07-17 20:14 PDT, Adam Barth 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-17 19:28:44 PDT 
@staticmethod
    def find_checkout_root(path):
        last_path = None
        while True:
            if not SVN.in_working_directory(path):
                return last_path
            last_path = path
            (path, last_component) = os.path.split(path)
            if last_path == path:
                return None


This code assumes the WebKit SVN checkout isn't nested in another SVN checkout.  This causes bugzilla-tool to fail for my hybrid Chromium/WebKit tree.
Comment 1 Adam Barth 2009-07-17 20:14:57 PDT 
Created attachment 33004 [details]
patch
Comment 2 David Levin 2009-07-17 20:22:14 PDT 
Comment on attachment 33004 [details]
patch

> +        # Seach up the directory hierarchy until we find a different UUID.
typo:Seach
Comment 3 Adam Barth 2009-07-17 20:30:20 PDT 
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/modules/scm.py
Transmitting file data ..
Committed revision 46082.
http://trac.webkit.org/changeset/46082
Comment 4 David Kilzer (:ddkilzer) 2010-03-22 11:45:48 PDT 
*** Bug 28925 has been marked as a duplicate of this bug. ***