WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
274035
Adopt SafeTextMarkerData in more places
https://bugs.webkit.org/show_bug.cgi?id=274035
Summary
Adopt SafeTextMarkerData in more places
Chris Dumez
Reported
2024-05-11 10:26:53 PDT
Adopt SafeTextMarkerData in more places.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-05-11 10:27:04 PDT
<
rdar://problem/127935353
>
Chris Dumez
Comment 2
2024-05-11 15:36:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/28435
EWS
Comment 3
2024-05-12 16:40:41 PDT
Committed
278666@main
(c0cc24bd0684): <
https://commits.webkit.org/278666@main
> Reviewed commits have been landed. Closing PR #28435 and removing active labels.
Diego Pino
Comment 4
2024-05-13 01:28:09 PDT
Build bot 'GTK-Linux-64-bit-Release-Debian-11-Build' if failing after this change with the following error:
https://build.webkit.org/#/builders/992/builds/2218
``` ./../../Source/WebCore/accessibility/AXTextMarker.cpp:157:28: error: ‘auto’ parameter not permitted in this context 157 | CharacterOffset result(RefPtr { m_data.node.get() }.get(), m_data.characterStart, m_data.characterOffset); | ^~~~~~ ```
Diego Pino
Comment 5
2024-05-13 01:28:34 PDT
Re-opening for pull request
https://github.com/webkit/webkit/pull/28459
EWS
Comment 6
2024-05-13 02:00:24 PDT
Committed
278677@main
(c7adbf8ae9c0): <
https://commits.webkit.org/278677@main
> Reviewed commits have been landed. Closing PR #28459 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug