Bug 274032 – [GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

https://github.com/WebKit/WebKit/blob/webkitgtk-2.45.1/Source/ThirdParty/skia/include/private/base/SkLoadUserConfig.h#L56

#if defined(SK_CPU_BENDIAN) && !defined(I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN)
    #error "The Skia team is not endian-savvy enough to support big-endian CPUs."
    #error "If you still want to use Skia,"
    #error "please define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN."
#endif

I confirm that it builds on s390x at least if I use -DUSE_SKIA=OFF so we should autodetect that situation.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/28429

[EWS]

Committed 278740@main (7a1468c7a3f3): <https://commits.webkit.org/278740@main>

Reviewed commits have been landed. Closing PR #28429 and removing active labels.

[Philippe Normand]

This broke builds where CMake is too old (3.16)...

CMake Error at Source/cmake/OptionsWPE.cmake:84 (if):                                                                                                                                                              
  if given arguments:                                                                                                                                                                                              
                                                                                                                                                                                                                   
    "3.16.9" "VERSION_LESS" "3.20" "OR" "STREQUAL" "LITTLE_ENDIAN"                                                                                                                                                 
                                                                                                                                                                                                                   
  Unknown arguments specified

[Michael Catanzaro]

Drat, I forgot we have to do it in two separate conditionals. I'll land a follow-up.

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/28540

[Diego Pino]

Many post-commit bots are currently failing and there's another build error that needs to be fixed.

https://build.webkit.org/#/builders/992

[EWS]

Committed 278764@main (9c1f32d066a4): <https://commits.webkit.org/278764@main>

Reviewed commits have been landed. Closing PR #28540 and removing active labels.