Bug 274011 – Fix RenderTreeBuilder::move() to clear percent height map

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While looking into old Blink's commit, I came across another failing test case:

Test Case - https://jsfiddle.net/nqt0g1yz/

^ Does not show 'blue' box in Safari / WebKit ToT while does show in Chrome Canary 126 and Firefox Nightly 127.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7afb0474da50c93fa2360fc70ccbb73a313a45f7

WebKit Source: https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#489 , https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp#545 and https://searchfox.org/wubkat/rev/5169139ac1127c419017b37d9f2106a2c199070f/Source/WebCore/rendering/RenderBlock.cpp#832

___

I did following changes and it compiles and progress following:

> RenderTreeBuilder::move() 

if (normalizeAfterInsertion == NormalizeAfterInsertion::Yes && is<RenderBlock>(from) && child.isRenderBox())
        RenderBlock::removePercentHeightDescendantIfNeeded(downcast<RenderBox>(child));

and

> RenderTreeBuilder::moveChildren() - Line 549

RenderBlock::removePercentHeightDescendantIfNeeded(*blockFlow);

and

RenderBlock::dirtyForLayoutFromPercentageHeightDescendants()

ASSERT(renderer->isDescendantOf(this));

___

Just raising so we can fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/128289804>

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/32064

[EWS]

Committed 282160@main (1223895a9c1b): <https://commits.webkit.org/282160@main>

Reviewed commits have been landed. Closing PR #32064 and removing active labels.