WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
273995
Replace unique frame names with frame identifiers in the history controller
https://bugs.webkit.org/show_bug.cgi?id=273995
Summary
Replace unique frame names with frame identifiers in the history controller
Charlie Wolfe
Reported
2024-05-10 02:56:44 PDT
With site isolation, unique frame names should not be used to identify frames. This patch replaces most of their usage in the history controller with frame identifiers. We cannot remove unique frame names from HistoryItem because logic in FrameLoader::loadURLIntoChildFrame requires us to match current frames with frames from a previous page. Unique frame names are also still used from session state and history test output.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-05-10 02:57:03 PDT
<
rdar://problem/127870100
>
Charlie Wolfe
Comment 2
2024-05-10 03:03:59 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/28385
EWS
Comment 3
2024-05-10 14:22:19 PDT
Committed
278629@main
(686240cb98d8): <
https://commits.webkit.org/278629@main
> Reviewed commits have been landed. Closing PR #28385 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug