ASSIGNED 273974
UNPACK_COLORSPACE_CONVERSION_WEBGL should only be used from texImage2D and texSubImage2D calls taking HTMLImageElement 
https://bugs.webkit.org/show_bug.cgi?id=273974
Summary UNPACK_COLORSPACE_CONVERSION_WEBGL should only be used from texImage2D and te...
Gerald Squelart
Reported 2024-05-09 14:54:08 PDT
According to the specs https://registry.khronos.org/webgl/specs/latest/1.0/#PIXEL_STORAGE_PARAMETERS : > UNPACK_COLORSPACE_CONVERSION_WEBGL of type unsigned long > If set to BROWSER_DEFAULT_WEBGL, then the browser's default colorspace conversion is applied during subsequent texImage2D and texSubImage2D calls taking HTMLImageElement. [...] > If the TexImageSource is an ImageBitmap, then [this] parameter will be ignored. But looking at the source code in WebGLRenderingContextBase.cpp, I see that it's used in `WebGLRenderingContextBase::texImageImpl`, which is called from `WebGLRenderingContextBase::texImageSource(..., HTMLImageElement& source)` (as expected), but also from others that take `ImageBitmap`, `HTMLCanvasElement`, etc. rdar://127580661
Attachments
Add attachment proposed patch, testcase, etc.
Gerald Squelart
Comment 1 2024-05-09 16:29:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28371
Note You need to log in before you can comment on or make changes to this bug.