Bug 273968 – AX: AXObjectCache::postPlatformNotification should take an AccessibilityObject not an AXCoreObject.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

.

[Radar WebKit Bug Importer]

<rdar://problem/127833247>

[Andres Gonzalez]

Created attachment 471344 [details]
Patch

[Andres Gonzalez]

Created attachment 471346 [details]
Patch

[Darin Adler]

Comment on attachment 471346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471346&action=review

> Source/WebCore/accessibility/AXObjectCache.h:598
> +    void postPlatformNotification(const AccessibilityObject&, AXNotification);

How about having this take a reference and not a const reference? Could avoid the const_cast and I think it makes logical sense either way.

[Andres Gonzalez]

Created attachment 471359 [details]
Patch

[Andres Gonzalez]

(In reply to Darin Adler from comment #4)
> Comment on attachment 471346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=471346&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:598
> > +    void postPlatformNotification(const AccessibilityObject&, AXNotification);
> 
> How about having this take a reference and not a const reference? Could
> avoid the const_cast and I think it makes logical sense either way.

Yes, done, thanks!

[EWS]

Committed 278653@main (3ced9c0227fc): <https://commits.webkit.org/278653@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471359 [details].

[Ross Kirsling]

Comment on attachment 471359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471359&action=review

> Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:91
> +        protectedObject = notifyChildrenSelectionChange(protectedObject.get());

This gives `no known conversion from 'WebCore::AXCoreObject *' to 'const WTF::RefPtr<WebCore::AccessibilityObject>'`.

[Ross Kirsling]

(In reply to Ross Kirsling from comment #8)
> Comment on attachment 471359 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=471359&action=review
> 
> > Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:91
> > +        protectedObject = notifyChildrenSelectionChange(protectedObject.get());
> 
> This gives `no known conversion from 'WebCore::AXCoreObject *' to 'const
> WTF::RefPtr<WebCore::AccessibilityObject>'`.

Fixing in https://github.com/WebKit/WebKit/pull/28453.