Bug 27388 - [Chromium] CSS dotted/dashed borders in Chromium/skia are generally hosed
: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally hosed
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: PC Windows XP
: P2 Normal
Assigned To:
: http://crbug.com/474
:
:
:
  Show dependency treegraph
 
Reported: 2009-07-17 14:21 PST by
Modified: 2009-07-27 17:51 PST (History)


Attachments
Fix for 1px CSS border issue (5.86 KB, patch)
2009-07-17 14:25 PST, Stephen White
eric: review+
Review Patch | Details | Formatted Diff | Diff
Revert of previous patch. (5.77 KB, patch)
2009-07-24 08:09 PST, Stephen White
no flags Review Patch | Details | Formatted Diff | Diff
Re-apply (unrevert) the patch. (5.82 KB, patch)
2009-07-27 07:09 PST, Stephen White
levin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-07-17 14:21:33 PST
Dotted and dashed 1px borders in Chromium/skia draw weird antialiased grey lines instead of distinct dots.

See: http://crbug.com/474
------- Comment #1 From 2009-07-17 14:25:33 PST -------
Created an attachment (id=32970) [details]
Fix for 1px CSS border issue
------- Comment #2 From 2009-07-20 15:13:57 PST -------
(From update of attachment 32970 [details])
Not much for me to say here.  As long as this passes tests, it looks sane.

Sad that we can't share more of this code.
------- Comment #3 From 2009-07-21 02:56:14 PST -------
Committed as http://trac.webkit.org/changeset/46157
------- Comment #4 From 2009-07-24 08:05:56 PST -------
This fix may be causing reliability problems in Chromium.  Reverting.
------- Comment #5 From 2009-07-24 08:09:23 PST -------
Created an attachment (id=33448) [details]
Revert of previous patch.
------- Comment #6 From 2009-07-24 09:05:32 PST -------
(From update of attachment 33448 [details])
Verified that it is simply a revert and (essentially) rubberstamping.
------- Comment #7 From 2009-07-24 10:44:41 PST -------
Landed as: http://trac.webkit.org/changeset/46363
------- Comment #8 From 2009-07-27 06:49:56 PST -------
Reopening this bug, since the fix was reverted.
------- Comment #9 From 2009-07-27 07:09:50 PST -------
Created an attachment (id=33544) [details]
Re-apply (unrevert) the patch.
------- Comment #10 From 2009-07-27 08:13:53 PST -------
(From update of attachment 33448 [details])
Clearing the r+ since this patch was applied (and the bug has ben re-opened).
------- Comment #11 From 2009-07-27 08:16:13 PST -------
(From update of attachment 33544 [details])
Really reviewed by Eric really. I verified that this is the same patch that Eric r+ before.
------- Comment #12 From 2009-07-27 17:51:09 PST -------
Committed (again) as http://trac.webkit.org/changeset/46447