Bug 273871 - Regression(278398@main): COG does not build for the first time with meson before 1.1.0
Summary: Regression(278398@main): COG does not build for the first time with meson bef...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Przemyslaw Gorszkowski
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2024-05-08 03:23 PDT by Przemyslaw Gorszkowski
Modified: 2024-05-14 03:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Gorszkowski 2024-05-08 03:23:29 PDT 
When webkit is built with COG from the scratch(for the first time, COG does not build, because recently added "--reconfigure" (278398@main) does not work with empty build folder with meson before 1.1.0 version. Comment from meson documentation:

"Since 1.1.0 --reconfigure is allowed even if the build directory does not already exist, that argument is ignored in that case."

It seems that we need to add some conditional using "--reconfigure" option in case of first build.
Comment 1 Przemyslaw Gorszkowski 2024-05-13 05:35:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28470
Comment 2 EWS 2024-05-14 03:01:06 PDT 
Committed 278747@main (b653500dcfab): <https://commits.webkit.org/278747@main>

Reviewed commits have been landed. Closing PR #28470 and removing active labels.