WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
27385
[chromium] build break in nprutime_internal.h
https://bugs.webkit.org/show_bug.cgi?id=27385
Summary
[chromium] build break in nprutime_internal.h
Eric Roman
Reported
2009-07-17 13:49:16 PDT
PluginDebug.cpp (a recently added file in
http://trac.webkit.org/changeset/46023
) tickled this problem. On mac/linux chromium the: #include "npapi.h" line in WebKit/WebCore/bindings/v8/npruntime_internal.h Ends up pulling in the wrong file. It pulls in: "src/third_party/npapi/bindings/npapi.h" Rather than: "src/third_party/WebKit/WebCore/bridge/npapi.h" The general problem is there are too many copies of npapi.h in chromium's code base: % find . -name "npapi.h" ./third_party/npapi/npspy/extern/plugin/npapi.h ./third_party/npapi/bindings/npapi.h ./third_party/WebKit/WebCore/bridge/npapi.h ./native_client/src/third_party/npapi/files/include/npapi.h And the include search path is probably wrong. Symptoms: In file included from /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/bindings/v8/npruntime_internal.h:31, from /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/PluginDebug.h:31, from /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/PluginDebug.cpp:29: /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/npfunctions.h:66: error: 'NPNURLVariable' has not been declared /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/npfunctions.h:67: error: 'NPNURLVariable' has not been declared /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/npfunctions.h:73: error: 'NPCoordinateSpace' has not been declared /b/slave/webkit-rel-linux-webkit-org/build/src/third_party/WebKit/WebCore/plugins/npfunctions.h:73: error: 'NPCoordinateSpace' has not been declared
Attachments
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-07-17 14:01:12 PDT
I'm not familiar with the header file and why there are so many copies (may be you can look at who added the file or who added the path the to the include path). General note: It seems odd that src/third_party/npapi/bindings/ is in the search path at all since chromium code usually has a path to includes. Perhaps the solution is to remove that from the path and qualify paths better that need to get to the copy there.
Eric Roman
Comment 2
2009-07-17 14:07:58 PDT
@levin: I believe it is being added by this:
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/npapi/npapi.gyp?view=markup
Eric Roman
Comment 3
2009-07-17 14:11:18 PDT
Perhaps then this is a gyp problem, where the include directories are being leaked outside of the specific target.
Eric Roman
Comment 4
2009-07-17 14:23:40 PDT
> Perhaps then this is a gyp problem, where the include directories > are being leaked outside of the specific target.
Apparently this is intentional, since it is within a "direct_dependent_settings" block.
Eric Roman
Comment 5
2009-07-17 14:47:49 PDT
Hacked around this chromium-side.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug