Bug 273838 – [JSC] Use simde in JSON

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

...

[Radar WebKit Bug Importer]

<rdar://problem/127688057>

[Yusuke Suzuki]

Pull request: https://github.com/WebKit/WebKit/pull/28251

[EWS]

Committed 278494@main (4855c7a1dc42): <https://commits.webkit.org/278494@main>

Reviewed commits have been landed. Closing PR #28251 and removing active labels.

[Carlos Alberto Lopez Perez]

This commit causes GCC 12 to crash.

Confirmed both cross-building for ARM64 with GCC 12.3.0 (from Yocto) as well as building natively for x86_64 with GCC 12.2.0 and GCC 12.3.0 from Debian:

./Source/JavaScriptCore/runtime/JSONObject.cpp: In lambda function:
./Source/JavaScriptCore/runtime/JSONObject.cpp:1124:89: internal compiler error: unexpected expression ‘static_cast<UnsignedType>('\"')’ of kind static_cast_expr
 1124 |                 constexpr auto quoteMask = WTF::splatBulk(static_cast<UnsignedType>('"'));
      |                                                                                         ^
0x7ffb005ff1c9 __libc_start_call_main
	../sysdeps/nptl/libc_start_call_main.h:58
0x7ffb005ff284 __libc_start_main_impl
	../csu/libc-start.c:360
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


It doesn't affect GCC 13 ... only version 12.

Will try to report a bug in the GCC bug-tracker and then we have to workaround this somehow here in WebKit for GCC-12 compilers

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #4)
> This commit causes GCC 12 to crash.
> Will try to report a bug in the GCC bug-tracker and then we have to
> workaround this somehow here in WebKit for GCC-12 compilers

Reported bug to GCC at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114997

[Carlos Alberto Lopez Perez]

Ok, this was already work-arounded here on https://commits.webkit.org/278511@main

[Mark Lam]

*** Bug 273791 has been marked as a duplicate of this bug. ***