Bug 27382 - Build break -- including a corefoundation header
Summary: Build break -- including a corefoundation header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Eric Roman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-17 11:44 PDT by Eric Roman
Modified: 2009-07-17 12:36 PDT (History)
1 user (show)

See Also:

Attachments
Add a header inclusion guard (1.06 KB, patch)
2009-07-17 12:05 PDT, Eric Roman 		darin: review-
Details | Formatted Diff | Diff
Add a header inclusion guard (v2) (1.13 KB, patch)
2009-07-17 12:18 PDT, Eric Roman 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Roman 2009-07-17 11:44:20 PDT 
http://trac.webkit.org/changeset/46042 add an include of "RetainPtr.h" in CollatorICU.cpp.

RetainPtr.h in turn includes:

include <CoreFoundation/CoreFoundation.h>

This breaks compile on non-mac builds for users of CollatorICU.cpp
(Broke chromium builder)
Comment 1 Eric Roman 2009-07-17 12:05:05 PDT 
Created attachment 32962 [details]
Add a header inclusion guard
Comment 2 Darin Adler 2009-07-17 12:09:21 PDT 
Comment on attachment 32962 [details]
Add a header inclusion guard

Conditionalized includes go in separate paragraphs in our coding style.

Typo "Build fox" instead of build fix. Would you be willing to do a new patch with those fixed?
Comment 3 Eric Roman 2009-07-17 12:18:07 PDT 
Created attachment 32964 [details]
Add a header inclusion guard (v2)

New patch -- addressed darin@apple.com's feedback.
Comment 4 Eric Roman 2009-07-17 12:36:53 PDT 
Landed in r46049.