RESOLVED FIXED Bug 27382
Build break -- including a corefoundation header 
https://bugs.webkit.org/show_bug.cgi?id=27382
Summary Build break -- including a corefoundation header
Eric Roman
Reported 2009-07-17 11:44:20 PDT
http://trac.webkit.org/changeset/46042 add an include of "RetainPtr.h" in CollatorICU.cpp. RetainPtr.h in turn includes: include <CoreFoundation/CoreFoundation.h> This breaks compile on non-mac builds for users of CollatorICU.cpp (Broke chromium builder)
Attachments
Add a header inclusion guard (1.06 KB, patch)
2009-07-17 12:05 PDT, Eric Roman 		darin: review-
DetailsFormatted DiffDiff
Add a header inclusion guard (v2) (1.13 KB, patch)
2009-07-17 12:18 PDT, Eric Roman 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Roman
Comment 1 2009-07-17 12:05:05 PDT
Created attachment 32962 [details] Add a header inclusion guard
Darin Adler
Comment 2 2009-07-17 12:09:21 PDT
Comment on attachment 32962 [details] Add a header inclusion guard Conditionalized includes go in separate paragraphs in our coding style. Typo "Build fox" instead of build fix. Would you be willing to do a new patch with those fixed?
Eric Roman
Comment 3 2009-07-17 12:18:07 PDT
Created attachment 32964 [details] Add a header inclusion guard (v2) New patch -- addressed darin@apple.com's feedback.
Eric Roman
Comment 4 2009-07-17 12:36:53 PDT
Landed in r46049.
Note You need to log in before you can comment on or make changes to this bug.