Bug 273794 – Drop StringTypeAdapter template specialization for `char*`

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Chris Dumez]

Drop StringTypeAdapter template specialization for `char*`. This is a step towards using either ASCIILiteral or std::span in string concatenation.

[Chris Dumez]

Pull request: https://github.com/WebKit/WebKit/pull/28201

[EWS]

Committed 278527@main (fe9b00cd8f13): <https://commits.webkit.org/278527@main>

Reviewed commits have been landed. Closing PR #28201 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/127765329>

[Diego Pino]

Build bot 'WPE-Linux-ARM32-bit-Release-Debian-Stable-Build' is failing with the following build error:

https://build.webkit.org/#/builders/860/builds/7888/steps/9/logs/stdio

```
../../../Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:1533:180:   required from here
WTF/Headers/wtf/text/StringConcatenate.h:543:38: error: invalid use of incomplete type ‘class WTF::StringTypeAdapter<char*, void>’
  543 |     return tryMakeStringFromAdapters(StringTypeAdapter<StringTypes>(strings)...);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from WTF/Headers/wtf/FileSystem.h:37,
                 from ../../../Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:29,
                 from ../../../Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannel.h:28,
                 from ../../../Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelGLib.cpp:27,
                 from DerivedSources/WebKit/unified-sources/UnifiedSource-72468c22-10.cpp:1:
WTF/Headers/wtf/Forward.h:106:43: note: declaration of ‘class WTF::StringTypeAdapter<char*, void>’
  106 | template<typename, typename = void> class StringTypeAdapter;
      |                                           ^~~~~~~~~~~~~~~~~
```

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/28347

[EWS]

Committed 278574@main (9c59162450fd): <https://commits.webkit.org/278574@main>

Reviewed commits have been landed. Closing PR #28347 and removing active labels.