WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
273790
Remove unneeded code in HistoryController::createItemTree
https://bugs.webkit.org/show_bug.cgi?id=273790
Summary
Remove unneeded code in HistoryController::createItemTree
Charlie Wolfe
Reported
2024-05-06 13:08:00 PDT
This code was added 16 years ago in
24907@main
. It was intended to fix an issue where reloading would create a history item for an <object> element that might not have loaded. Today, history items are not created upon reloading. With site isolation, we are not always able to check if a child frame has loaded, so we should just remove this code.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-05-06 13:08:17 PDT
<
rdar://problem/127621115
>
Charlie Wolfe
Comment 2
2024-05-06 13:09:42 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/28198
EWS
Comment 3
2024-05-06 17:32:11 PDT
Committed
278433@main
(1be8c36a062c): <
https://commits.webkit.org/278433@main
> Reviewed commits have been landed. Closing PR #28198 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug