Bug 273790 - Remove unneeded code in HistoryController::createItemTree
Summary: Remove unneeded code in HistoryController::createItemTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Wolfe
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-06 13:08 PDT by Charlie Wolfe
Modified: 2024-05-06 17:32 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Wolfe 2024-05-06 13:08:00 PDT
This code was added 16 years ago in 24907@main. It was intended to fix an issue where reloading would create a history item for an <object> element that might not have loaded. Today, history items are not created upon reloading. With site isolation, we are not always able to check if a child frame has loaded, so we should just remove this code.
Comment 1 Radar WebKit Bug Importer 2024-05-06 13:08:17 PDT
<rdar://problem/127621115>
Comment 2 Charlie Wolfe 2024-05-06 13:09:42 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28198
Comment 3 EWS 2024-05-06 17:32:11 PDT
Committed 278433@main (1be8c36a062c): <https://commits.webkit.org/278433@main>

Reviewed commits have been landed. Closing PR #28198 and removing active labels.