Bug 273780 - [GTK] Consider keycode when activating application accelerators
Summary: [GTK] Consider keycode when activating application accelerators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-06 10:36 PDT by Michael Catanzaro
Modified: 2024-05-07 05:34 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2024-05-06 10:36:11 PDT 
Moving this from https://gitlab.gnome.org/GNOME/epiphany/-/issues/2312, the problem is since Epiphany 46 keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well.

E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T.
Comment 1 Michael Catanzaro 2024-05-06 10:40:53 PDT 
(This is *sort of* a regression from 273922@main, except in practice it probably only affects Epiphany. Only matters if the application allows the web view to process key events before it allows its GtkWindow to do so, which has to be done manually.)
Comment 2 Michael Catanzaro 2024-05-06 10:44:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28181
Comment 3 EWS 2024-05-07 05:34:51 PDT 
Committed 278456@main (48d82b12d119): <https://commits.webkit.org/278456@main>

Reviewed commits have been landed. Closing PR #28181 and removing active labels.