Bug 273780 – REGRESSION(273922@main): [GTK] Epiphany keyboard shortcuts broken with non-Latin keyboard layout

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Moving this from https://gitlab.gnome.org/GNOME/epiphany/-/issues/2312, the problem is since Epiphany 46 keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well.

E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T.

[Michael Catanzaro]

(This is *sort of* a regression from 273922@main, except in practice it probably only affects Epiphany. Only matters if the application allows the web view to process key events before it allows its GtkWindow to do so, which has to be done manually.)

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/28181

[EWS]

Committed 278456@main (48d82b12d119): <https://commits.webkit.org/278456@main>

Reviewed commits have been landed. Closing PR #28181 and removing active labels.

[Michael Catanzaro]

Reopening because something is wrong and this isn't working. See: https://gitlab.gnome.org/GNOME/epiphany/-/issues/2396

[Michael Catanzaro]

gtk_accelerator_name_with_keycode() is returning "<Control>hebrew_aleph" which of course doesn't match any actions. So that doesn't work at all.

But three months ago, I was convinced that it did work. The question is why. Did I trick myself, or did something change?

[Michael Catanzaro]

Guess: this never worked, and I tricked myself by testing on about:overview, where the web view is not focused and not actually receiving the key press events?

[Michael Catanzaro]

I don't have a solution for this.

We might need to revert 273922@main, which would be unfortunate because that will bring back other serious bugs, but at least then all keyboard layouts would be equally broken. (I hesitate to treat non-Latin keyboard layouts worse off than Latin layouts.)

[darkblaze69]

fwiw, libreoffice in gtk4 also suffers from this issue. Is it maybe more general issue in gtk4?

https://bugs.documentfoundation.org/show_bug.cgi?id=161589

[Michael Catanzaro]

No, this is a WebKit bug.

[Michael Catanzaro]

Let's bring back key event reinjection to get back to the state we had before I broke Hebrew/Ukrainian keyboards. That won't work properly either, but at least it will be equally broken for everyone.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/33242

[EWS]

Committed 283267@main (5978873cc8be): <https://commits.webkit.org/283267@main>

Reviewed commits have been landed. Closing PR #33242 and removing active labels.