Bug 273711 – AX: Moving testing only attributes in WebAccessibilityObjectWrapperMac.mm to attributeValueForTesting

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

This is a tiny performance improvement and code cleanup.

[Radar WebKit Bug Importer]

<rdar://problem/127512021>

[Tyler Wilcock]

Created attachment 471274 [details]
Patch

[chris fleizach]

Comment on attachment 471274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471274&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2321
> +        return [NSNumber numberWithBool: backingObject->isIndeterminate()];

should fix this spacing
hBool: backingObjec

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2323
> +    if ([attributeName isEqualToString:@"AXIsMultiSelectable"])

we're sure all of these are not used by VO?

[Tyler Wilcock]

Created attachment 471276 [details]
Patch

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 471274 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=471274&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2321
> > +        return [NSNumber numberWithBool: backingObject->isIndeterminate()];
> 
> should fix this spacing
> hBool: backingObjec
Fixed!

> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2323
> > +    if ([attributeName isEqualToString:@"AXIsMultiSelectable"])
> 
> we're sure all of these are not used by VO?
Yep, just re-confirmed none of these are used by VoiceOver or any other assistive technology.

[EWS]

Committed 278375@main (06293e14f619): <https://commits.webkit.org/278375@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471276 [details].