RESOLVED FIXED 27369
[v8] Restore proxy retrieval lost in -r45596 
https://bugs.webkit.org/show_bug.cgi?id=27369
Summary [v8] Restore proxy retrieval lost in -r45596
anton muhin
Reported 2009-07-17 05:48:15 PDT
In my change list (http://trac.webkit.org/changeset?old_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&old=45595&new_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&new=45596) I made a typo and instead: 2414 if (!proxy) 2415 proxy = V8Proxy::retrieve(); I put 2414 if (!proxy) 2415 V8Proxy* proxy = V8Proxy::retrieve(); which made us notably slower. Those line later were refactored, so change looks somewhat different.
Attachments
Initial version (1.32 KB, patch)
2009-07-17 05:53 PDT, anton muhin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2009-07-17 05:53:29 PDT
Created attachment 32934 [details] Initial version
Mads Ager
Comment 2 2009-07-17 09:49:34 PDT
Looks good to me. Over to Dimitri for the official review.
Dimitri Glazkov (Google)
Comment 3 2009-07-17 11:18:27 PDT
Comment on attachment 32934 [details] Initial version ok.
Jeremy Orlow
Comment 4 2009-07-17 19:03:50 PDT
Assigning for landing
Jeremy Orlow
Comment 5 2009-07-17 19:15:17 PDT
Landed in r46079
anton muhin
Comment 6 2009-07-20 04:34:09 PDT
(In reply to comment #5) > Landed in r46079 Thank you, everyone.
Note You need to log in before you can comment on or make changes to this bug.