Bug 27369 - [v8] Restore proxy retrieval lost in -r45596
Summary: [v8] Restore proxy retrieval lost in -r45596
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-17 05:48 PDT by anton muhin
Modified: 2009-07-20 04:34 PDT (History)
3 users (show)

See Also:

Attachments
Initial version (1.32 KB, patch)
2009-07-17 05:53 PDT, anton muhin 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2009-07-17 05:48:15 PDT 
In my change list (http://trac.webkit.org/changeset?old_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&old=45595&new_path=%2Ftrunk%2FWebCore%2Fbindings%2Fv8&new=45596) I made a typo and instead:

2414	    if (!proxy) 
2415	        proxy = V8Proxy::retrieve(); 

I put

2414	    if (!proxy) 
2415	        V8Proxy* proxy = V8Proxy::retrieve(); 

which made us notably slower.

Those line later were refactored, so change looks somewhat different.
Comment 1 anton muhin 2009-07-17 05:53:29 PDT 
Created attachment 32934 [details]
Initial version
Comment 2 Mads Ager 2009-07-17 09:49:34 PDT 
Looks good to me.  Over to Dimitri for the official review.
Comment 3 Dimitri Glazkov (Google) 2009-07-17 11:18:27 PDT 
Comment on attachment 32934 [details]
Initial version

ok.
Comment 4 Jeremy Orlow 2009-07-17 19:03:50 PDT 
Assigning for landing
Comment 5 Jeremy Orlow 2009-07-17 19:15:17 PDT 
Landed in r46079
Comment 6 anton muhin 2009-07-20 04:34:09 PDT 
(In reply to comment #5)
> Landed in r46079

Thank you, everyone.