Bug 27368 - [Qt] On Symbian link against the system sqlite3
: [Qt] On Symbian link against the system sqlite3
Product: WebKit
Classification: Unclassified
Component: WebKit Qt
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To: Nobody
Depends on:
Blocks: 27065
  Show dependency treegraph
Reported: 2009-07-17 05:47 PDT by Laszlo Gombos
Modified: 2009-07-20 02:45 PDT (History)
3 users (show)

See Also:

First try. (2.85 KB, patch)
2009-07-17 05:59 PDT, Laszlo Gombos
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-07-17 05:47:14 PDT
QtWebKit allows linking against sqlite3 from the OS or pick up the sqlite sources and link in sqlite3 statically into QtWebKit library.

On Symbian the syntax for linking against the OS sqlite3 is a slightly different than on other OS's.
Comment 1 Laszlo Gombos 2009-07-17 05:59:02 PDT
Created attachment 32935 [details]
First try.

Add an option for all Qt builds to force linking against system sqlite3 by adding system-sqlite to the CONFIG variable - up until now this was only an option for QTDIR_build builds.

The symbian specific part of this patch is contributed by Norbert Leser.
Comment 2 Holger Freyther 2009-07-17 18:08:05 PDT
Comment on attachment 32935 [details]
First try.

> +            INCLUDEPATH += $${SQLITE3SRCDIR}
> +            symbian: LIBS += -lsqlite3.lib
> +            else: LIBS += -lsqlite3

Looks good, it might look like the else is not properly indented... please check that when landing.
Comment 3 Simon Hausmann 2009-07-20 02:45:11 PDT
Landed in 46112. qmake's syntax is funny at times, the else was correct :)