Bug 273606 - [WebGPU] GPUBuffer should not destroy the underlying buffer from its destructor
Summary: [WebGPU] GPUBuffer should not destroy the underlying buffer from its destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Wyrzykowski
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-01 22:21 PDT by Mike Wyrzykowski
Modified: 2024-05-06 10:48 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2024-05-01 22:21:45 PDT 
[WebGPU] RenderPipeline does not retain the buffers it uses, leading to the possibility of the buffer being destroyed
Comment 1 Radar WebKit Bug Importer 2024-05-01 22:22:03 PDT 
<rdar://problem/127408015>
Comment 2 Mike Wyrzykowski 2024-05-01 22:28:04 PDT 
This is actually in the encoders, updating title. It leads to the possibility of the buffer being destroyed before the command buffer is submitted
Comment 3 Mike Wyrzykowski 2024-05-02 11:32:09 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28051
Comment 4 EWS 2024-05-06 10:48:40 PDT 
Committed 278412@main (0a9423a613b0): <https://commits.webkit.org/278412@main>

Reviewed commits have been landed. Closing PR #28051 and removing active labels.