Bug 27360 - [Chromium] Fix build with DOM_STORAGE enabled.
Summary: [Chromium] Fix build with DOM_STORAGE enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-16 20:28 PDT by Jeremy Orlow
Modified: 2009-07-17 00:43 PDT (History)
1 user (show)

See Also:

Attachments
v1 (1.60 KB, patch)
2009-07-16 20:33 PDT, Jeremy Orlow 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-07-16 20:28:05 PDT 
A few small changes so Chromium builds with DOM_STORAGE enabled.
Comment 1 Jeremy Orlow 2009-07-16 20:33:54 PDT 
Created attachment 32912 [details]
v1

* bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp files.
* storage/StorageAreaImpl.cpp:  #include "DOMWindow.h"

I'm sorry this didn't get attached to my previous v8 patch, but I _think_ this is the last change that needs to be made.
Comment 2 David Levin 2009-07-16 21:09:20 PDT 
Comment on attachment 32912 [details]
v1

Two nits which I can fix up on landing.

> Index: WebCore/ChangeLog
> +        * bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp files.
Typo: ccp

> Index: WebCore/storage/StorageAreaImpl.cpp

>  #include "EventNames.h"
>  #include "ExceptionCode.h"
> +#include "DOMWindow.h"
>  #include "Frame.h"

Out of alphabetical order.
Comment 3 Jeremy Orlow 2009-07-16 21:15:26 PDT 
Sorry about that!  I should have looked closer before uploading apparently.  :-(
Comment 4 David Levin 2009-07-17 00:13:22 PDT 
Assign to levin for landing.
Comment 5 David Levin 2009-07-17 00:43:52 PDT 
Committed as http://trac.webkit.org/changeset/46022