Bug 273584 – AX: aria-describedby text can become stale after the targeted element changes its subtree

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Failing to do so results in stale content being served to ATs.

[Radar WebKit Bug Importer]

<rdar://problem/127390465>

[Tyler Wilcock]

Created attachment 471242 [details]
Patch

[Tyler Wilcock]

Created attachment 471243 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Created attachment 471243 [details]
> Patch

diff --git a/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp b/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
index de523f8a5657..1f7d40d65b1f 100644
--- a/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
+++ b/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
@@ -772,11 +772,15 @@ void AXIsolatedTree::updateDependentProperties(AccessibilityObject& axObject)
     ASSERT(isMainThread());

     auto updateLabeledObjects = [this] (const AccessibilityObject& label) {
-        auto labeledObjects = label.labelForObjects();
-        for (const auto& labeledObject : labeledObjects) {
+        for (const auto& labeledObject : label.labelForObjects()) {
             if (RefPtr axObject = downcast<AccessibilityObject>(labeledObject.get()))
                 queueNodeUpdate(axObject->objectID(), NodeUpdateOptions::nodeUpdate());
         }
+
+        for (const auto& describedByObject : label.descriptionForObjects()) {
+            if (RefPtr axObject = downcast<AccessibilityObject>(describedByObject.get()))
+                queueNodeUpdate(axObject->objectID(), { { AXPropertyName::AccessibilityText, AXPropertyName::ExtendedDescription } });
+        }
     };

AG: looks good, just maybe rename the lambda since it is no longer for labeled objects, but also for described objects.

     updateLabeledObjects(axObject);

[Tyler Wilcock]

Created attachment 471264 [details]
Patch

[EWS]

Committed 278318@main (65862d818c5d): <https://commits.webkit.org/278318@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471264 [details].