RESOLVED FIXED 273576
Add assert in JSObject::getOwnNonIndexPropertySlot 
https://bugs.webkit.org/show_bug.cgi?id=273576
Summary Add assert in JSObject::getOwnNonIndexPropertySlot
Marcus Plutowski
Reported 2024-05-01 13:59:00 PDT
rdar://127365044 Currently `JSObject::getOwnNonIndexPropertySlot` checks to make sure the type of the cell matches, but does not make sure that the PropertyAttributes include Accessor; for debugging purposes it would be helpful to add a check for that inside the function so that the issue shows up right away rather than somewhere downstream.
Attachments
Add attachment proposed patch, testcase, etc.
Marcus Plutowski
Comment 1 2024-05-01 14:07:23 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28005
EWS
Comment 2 2024-05-08 11:51:17 PDT
Committed 278518@main (108a035df97d): <https://commits.webkit.org/278518@main> Reviewed commits have been landed. Closing PR #28005 and removing active labels.
Marcus Plutowski
Comment 3 2024-05-10 15:39:22 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/28414
Mark Lam
Comment 4 2024-05-13 17:05:56 PDT
We decided that ttps://github.com/WebKit/WebKit/pull/28414 is not worth doing. The previous commit is sufficient.
Note You need to log in before you can comment on or make changes to this bug.