Bug 273553 – Test for parsing XML with WebCore and libxml2 in the same process

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Test for parsing XML with WebCore and libxml2 in the same process.

Adding a test for this fix:

    [WK1] WebKit XML parsing can deny external entity loads from other in-process libxml2 clients
    https://bugs.webkit.org/show_bug.cgi?id=273045
    <rdar://126476952>
    <https://commits.webkit.org/278168@main>

<rdar://127295719>

[David Kilzer (:ddkilzer)]

Verified the new API test breaks (as expected) when locally reverting the fix for Bug 273045:

$ ./Tools/Scripts/run-api-tests --no-timeout --no-build --release TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2
Running tests       

OpenSource/Tools/TestWebKitAPI/Tests/WebCore/XMLParsing.mm:47
Value of: !!doc
  Actual: false
Expected: true


worker/0 TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2 Failed
Ran 1 tests of 1 with 0 successful
------------------------------
Test suite failed

Failed

    TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2
        OpenSource/Tools/TestWebKitAPI/Tests/WebCore/XMLParsing.mm:47Value of: !!doc  Actual: falseExpected: true

[David Kilzer (:ddkilzer)]

Pull request: https://github.com/WebKit/WebKit/pull/27989

[EWS]

Committed 278253@main (8130984fb356): <https://commits.webkit.org/278253@main>

Reviewed commits have been landed. Closing PR #27989 and removing active labels.

[David Kilzer (:ddkilzer)]

Re-opening for pull request https://github.com/WebKit/WebKit/pull/28118

[EWS]

Committed 278359@main (a759149fe1d9): <https://commits.webkit.org/278359@main>

Reviewed commits have been landed. Closing PR #28118 and removing active labels.