Bug 27352 - Video size sometimes jumps just after the video starts loading
Summary: Video size sometimes jumps just after the video starts loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-16 14:36 PDT by Simon Fraser (smfr)
Modified: 2009-07-16 18:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch, changelog (3.04 KB, patch)
2009-07-16 14:39 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-07-16 14:36:04 PDT 
With hardware-accelerated video, sometimes the size jumps just after the video starts loading. It's an ordering problem where we end up creating the video rendering before the intrinsic size is known.
Comment 1 Simon Fraser (smfr) 2009-07-16 14:39:52 PDT 
Created attachment 32893 [details]
Patch, changelog
Comment 2 Darin Adler 2009-07-16 14:41:29 PDT 
Comment on attachment 32893 [details]
Patch, changelog

> +    bool readyForRendering() const;

I think it would be slightly better to call this isReadyForRendering for two reasons.

    1) "ready" is verb as well as an adjective.
    2) Without the "is", the function seems like it might be the caller saying we are ready, rather than asking.

r=me
Comment 3 Simon Fraser (smfr) 2009-07-16 18:33:04 PDT 
http://trac.webkit.org/changeset/45986