Bug 27345 - [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
Summary: [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Qt
Depends on:
Blocks:
 
Reported: 2009-07-16 05:04 PDT by Holger Freyther
Modified: 2009-07-17 09:06 PDT (History)
0 users

See Also:


Attachments
[GTK+] Update the focus handling code. (2.38 KB, patch)
2009-07-16 05:36 PDT, Holger Freyther
no flags Details | Formatted Diff | Diff
[GTK+] Make TestNescpaePlugin loadable in mozilla (1.45 KB, patch)
2009-07-16 06:01 PDT, Holger Freyther
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-07-16 05:04:31 PDT
The TestNetscapePlugin can not be loaded in gecko because WebKit's NPNetscapeFuncs contain two more entries.
Comment 1 Holger Freyther 2009-07-16 05:36:33 PDT
Created attachment 32864 [details]
[GTK+] Update the focus handling code.

Make sure to call FocusController::setFocusedFrame when
we didn't set a focused frame yet. We are doing this in
the grab-focus and focus-in routine.
---
 2 files changed, 30 insertions(+), 3 deletions(-)
Comment 2 Holger Freyther 2009-07-16 06:01:53 PDT
Created attachment 32866 [details]
[GTK+] Make TestNescpaePlugin loadable in mozilla

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.
---
 2 files changed, 13 insertions(+), 2 deletions(-)
Comment 3 Simon Hausmann 2009-07-17 00:32:17 PDT
Comment on attachment 32866 [details]
[GTK+] Make TestNescpaePlugin loadable in mozilla

r=me, I guess the same applies to the check below?
Comment 4 Holger Freyther 2009-07-17 08:57:25 PDT
Commited in r46036. Let me think about the other change.