Bug 27342 - Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
Summary: Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-16 03:11 PDT by Zoltan Horvath
Modified: 2009-07-25 15:14 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (1.20 KB, patch)
2009-07-16 03:13 PDT, Zoltan Horvath 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-16 03:11:36 PDT 
Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.
Comment 1 Zoltan Horvath 2009-07-16 03:13:15 PDT 
Created attachment 32850 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-07-20 15:08:23 PDT 
Comment on attachment 32850 [details]
proposed patch

Seems fine to me.  Whoever lands this needs to make sure to build and run tests
("bugzilla-tool land-patches 27342" will do that for you).
Comment 3 Adam Barth 2009-07-22 21:36:24 PDT 
I'm going to try one of these again.  Eric, always pimping the bugzilla-tool.
Comment 4 Adam Barth 2009-07-22 22:02:46 PDT 
I have no idea why, but these patches don't agree with my machine.  History suggests that other people won't have trouble with the patch.
Comment 5 Adam Barth 2009-07-25 15:13:39 PDT 
Ok.  I'm going to live on the edge and give this one to the bots.
Comment 6 Adam Barth 2009-07-25 15:14:21 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/API/JSObjectRef.cpp
	M	JavaScriptCore/ChangeLog
Committed r46401
	M	JavaScriptCore/API/JSObjectRef.cpp
	M	JavaScriptCore/ChangeLog
r46401 = 8bdbc6b4591eee273bddec9d2fa419147fec5a56 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46401