WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
273316
[GTK][WPE][Skia] Disable accelerated ImageBitmap support
https://bugs.webkit.org/show_bug.cgi?id=273316
Summary
[GTK][WPE][Skia] Disable accelerated ImageBitmap support
Miguel Gomez
Reported
2024-04-26 05:10:21 PDT
ImageBitmap is backed by an ImageBuffer whose implementation can be accelerated or not. In order to create the accelerated ImageBuffer for this, we need to make the skiaGLContext current. But ImageBitmaps can be created in worker threads, which requires making the skiaGLContext current in that thread, when it's intended to be used in the main thread only. This can cause glitches or even crashes. In order to fix this, we need to add support for having per thread skiaGLContexts, so each thread has its own context and doesn't mess with the others. But this is not as urgent at this point of the migration. For the moment we're disabling the accelerated support for ImageBitmaps, which removes the problem. We will be back to this a bit later, when we add the implementation for the offscreen canvas, where per thread gl contexts are required.
Attachments
Add attachment
proposed patch, testcase, etc.
Miguel Gomez
Comment 1
2024-04-26 05:39:13 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/27798
EWS
Comment 2
2024-04-26 08:20:58 PDT
Committed
278041@main
(8f40df743d93): <
https://commits.webkit.org/278041@main
> Reviewed commits have been landed. Closing PR #27798 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug