Bug 273248 – AX: Implement off-main-thread support for AXTextMarkerRangeForLineAttribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

...

[Radar WebKit Bug Importer]

<rdar://problem/127052882>

[Tyler Wilcock]

Created attachment 471127 [details]
Patch

[Tyler Wilcock]

Created attachment 471135 [details]
Patch

[chris fleizach]

Comment on attachment 471135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471135&action=review

> Source/WebCore/accessibility/AXTextMarker.h:199
> +    AXTextMarkerRange markerRangeForLine(unsigned lineIndex) const;

markerRangeForLineIndex(unsigned)

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2351
> +    else if ([parameter isKindOfClass:[NSValue class]] && !strcmp([(NSValue*)parameter objCType], @encode(NSRange)))

NSValue *

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3797
> +    if (AXObjectCache::clientIsInTestMode()) {

UNLIKELY()

[Tyler Wilcock]

Created attachment 471181 [details]
Patch

[Tyler Wilcock]

(In reply to chris fleizach from comment #4)
> Comment on attachment 471135 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=471135&action=review
> 
> > Source/WebCore/accessibility/AXTextMarker.h:199
> > +    AXTextMarkerRange markerRangeForLine(unsigned lineIndex) const;
> 
> markerRangeForLineIndex(unsigned)
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2351
> > +    else if ([parameter isKindOfClass:[NSValue class]] && !strcmp([(NSValue*)parameter objCType], @encode(NSRange)))
> 
> NSValue *
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3797
> > +    if (AXObjectCache::clientIsInTestMode()) {
> 
> UNLIKELY()
AXObjectCache::clientIsInTestMode() is defined wrapping the entire expression in UNLIKELY, so we shouldn't need it at any callsites. Addressed the other two comments, thanks!

bool AXObjectCache::clientIsInTestMode()
{
    return UNLIKELY(isTestAXClientType(_AXGetClientForCurrentRequestUntrusted()));
}

[EWS]

Committed 278081@main (1dd6d95b8d00): <https://commits.webkit.org/278081@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471181 [details].