Bug 27324 – Add ENABLE_RUBY to list of build options

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Roland Steiner]

In order to implement HTML5 ruby support, a new build option ENABLE_RUBY is required.

[Roland Steiner]

Created attachment 32822 [details]
patch: add ENABLE_RUBY build option

Further outtake from larger ruby patch submitted to bug #3749, in order to reduce patch sizes.

This patch only adds the build options, but no actual functionality.

[Roland Steiner]

Created attachment 32824 [details]
patch: add ENABLE_RUBY build option

Upload correct file. :p

[David Levin]

Comment on attachment 32824 [details]
patch: add ENABLE_RUBY build option

Address the following few issues and I think it will be ready to land.

Two issues:
1. You appear to be missing changes to trunk/WebCore/GNUmakefile.am and trunk/WebCore/WebCore.vcproj/WebCoreCommon.vsprops (see http://trac.webkit.org/changeset/46021 for example changes to these files).
2. The changelog should have the following:

  Date Name line

  Reviewed by NOBODY (OOPS!).

  >Bug Title<
  >Bug Link<

  Description of change.

a. Your change logs appears to be missing the items in ><
b. Your description line seems to need to be indented one more space.

[Roland Steiner]

Created attachment 33147 [details]
patch: add ENABLE_RUBY build option (fixed patch)

Uploaded a fixed patch that should address all mentioned issues.

(FWIW, my original ruby patch did include GNUMakefile.am, must have been a casualty of the patch split :p)

[David Levin]

Comment on attachment 33147 [details]
patch: add ENABLE_RUBY build option (fixed patch)


> Index: WebKitTools/Scripts/build-webkit
> @@ -88,6 +88,9 @@ my @features = (
>      { option => "shared-workers", desc => "Toggle SharedWorkers support",
>        define => "ENABLE_SHARED_WORKERS", default => 0, value => \$sharedWorkersSupport },
>  
> +    { option => "ruby", desc => "Toggle HTML5 Ruby support",
> +      define => "ENABLE_RUBY", default => 1, value => \$rubySupport },
> +

To whoever is landing this one option is just slightly out of sort order so this should be fixed on landing.

>      { option => "svg", desc => "Toggle SVG support",

[David Levin]

Committed as http://trac.webkit.org/changeset/46159