Bug 27321 - v8 bindings missing from the build
Summary: v8 bindings missing from the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-15 15:44 PDT by Andrew Wilson
Modified: 2009-07-16 17:38 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true (6.52 KB, patch)
2009-07-16 12:04 PDT, Andrew Wilson 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-07-15 15:44:37 PDT 
In addition to being added to the .gypi files, apparently all new V8 bindings must also be added to the DerivedSourcesAllInOne.cpp file.

Both V8AbstractWorker.cpp and V8SharedWorker.cpp are missing from this file, which causes link errors in Chromium when SHARED_WORKERS is enabled.
Comment 1 Andrew Wilson 2009-07-15 17:05:31 PDT 
Also, the vcproj files are missing the SHARED_WORKER flags and associated files.
Comment 2 Andrew Wilson 2009-07-16 12:03:48 PDT 
Of course, since the V8 bindings are missing, the JSC bindings were also missing.

I'm chagrined to find that we manually keep parallel lists of DerivedSources files separate from the build config. Who knew?
Comment 3 Andrew Wilson 2009-07-16 12:04:47 PDT 
Created attachment 32885 [details]
proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true
Comment 4 David Levin 2009-07-16 13:17:26 PDT 
Comment on attachment 32885 [details]
proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true

The new modes being set on:
 WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp
 WebCore/bindings/v8/custom/V8SharedWorkerCustom.cpp

Seem odd (to both of us).  I'll remove them from the patch when I land it.
Comment 5 David Levin 2009-07-16 13:18:19 PDT 
Assigned to levin for landing.
Comment 6 David Levin 2009-07-16 17:38:11 PDT 
Committed as http://trac.webkit.org/changeset/45997