Bug 273206 – AX: Remove several unused word, sentence, and paragraph position functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

...

[Radar WebKit Bug Importer]

<rdar://problem/127000726>

[Tyler Wilcock]

Created attachment 471108 [details]
Patch

[Tyler Wilcock]

Created attachment 471118 [details]
Patch

[chris fleizach]

Comment on attachment 471118 [details]
Patch

Could have swore we had Mac functions with markers to use these. Why and when were they added? Did we use to have a marker interface?

[Tyler Wilcock]

(In reply to chris fleizach from comment #4)
> Comment on attachment 471118 [details]
> Patch
> 
> Could have swore we had Mac functions with markers to use these. Why and
> when were they added? Did we use to have a marker interface?
These existed before 2008, but the git history doesn't go back any farther:

https://github.com/WebKit/WebKit/commit/8486f1fe2dbeef8ae18aa9198fa56eebd3543a01#diff-e8db8bb19347472225640770719ab1678c0a95100df8cf27d1beb3a536717dcc

These functions stopped being called in these commits:

https://github.com/WebKit/WebKit/commit/9510dea2c8571c731e1450a64ebb77a4b415dabc
https://github.com/WebKit/WebKit/commit/8d97d59fcdf545e5cb25fbebb472e49b233256f2
https://github.com/WebKit/WebKit/commit/c67290aee69c9fd2fa709067c3f902e1d34ef912

(Commit titles are implement word / sentence / paragraph functionality using TextIterator)

The attributes that were associated with these functions still exist and are used, but now have a different implementation, e.g.:

if ([attribute isEqualToString:AXPreviousSentenceStartTextMarkerForTextMarkerAttribute])
    return (id)[self textMarkerForTextMarker:textMarker atUnit:TextUnit::PreviousSentenceStart];

[Tyler Wilcock]

Created attachment 471132 [details]
Patch

[EWS]

Committed 278019@main (ffd9b9de8c8a): <https://commits.webkit.org/278019@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471132 [details].