v8::Local<v8::Object> V8DOMWrapper::instantiateV8Object(V8Proxy* proxy, ... ... if (!proxy) V8Proxy* proxy = V8Proxy::retrieve(); proxy is declared as a local variable in the if clause, which shadows the function parameter of the same name. This is a typo. I will attach a patch which fixes this issue.
Created attachment 32797 [details] Patch which removes the local variable
Comment on attachment 32797 [details] Patch which removes the local variable + No test required as this change does not affect layout. You should say that no test is required because this change does not change our behavior. The LayoutTests test much more than just layout. :)
Created attachment 32800 [details] Patch2: modified the changelog
Comment on attachment 32800 [details] Patch2: modified the changelog Thanks!
Will land.
Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.cpp Transmitting file data .. Committed revision 45965.