Bug 27295 - The Qt DRT pops up message boxes when javascript execution takes too long
Summary: The Qt DRT pops up message boxes when javascript execution takes too long
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 26886
  Show dependency tree / graph
 
Reported: 2009-07-15 05:46 PDT by Simon Hausmann
Modified: 2009-07-15 05:51 PDT (History)
0 users

See Also:

Attachments
patch to re-implement shouldInterruptJavaScript() in Qt DRT (1.27 KB, patch)
2009-07-15 05:46 PDT, Simon Hausmann 		manyoso: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2009-07-15 05:46:55 PDT 
Created attachment 32779 [details]
patch to re-implement shouldInterruptJavaScript() in Qt DRT

Tests like fast/js/try-catch-crash.html take a long time with debug builds and the interpreter and may result in a message box popping up.

Qt DRT should re-implement QWebPage::shouldInterruptJavaScript() and return false, to avoid the message boxes. The run-webkit-tests counterpart takes care of the timeout handling.
Comment 1 Simon Hausmann 2009-07-15 05:51:54 PDT 
Landed in r45906