Bug 272933 – [ews-build.webkit.org] RevertPullRequestChanges doesn't apply to patches

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryan Haddad]

In https://bugs.webkit.org/show_bug.cgi?id=272570, the mac-wk2 bubble was green. However, the change ended up introducing the two consistent test failures documented in https://bugs.webkit.org/show_bug.cgi?id=272930

Looking at the test run in https://ews-build.webkit.org/#/builders/36/builds/43315, the two tests in question failed on the first run, the retry run, and (unexpectedly!!) the run-layout-tests-without-change step, which caused them to be considered pre-existing failures.

[Ryan Haddad]

I don't see anything obviously wrong when looking at the test run.

One thing of note is that this was a patch, not a PR. Is there a chance that we broke something in the unapply-patch step?

[alan baradlay]

This has happened again at bug 272944

[Radar WebKit Bug Importer]

<rdar://problem/126774529>

[Ryan Haddad]

(In reply to zalan from comment #2)
> This has happened again at bug 272944

https://bugs.webkit.org/show_bug.cgi?id=272570 is the bug for the change that caused the failure.  https://ews-build.webkit.org/#/builders/50/builds/19642 is the example of the crash showing up in the run-layout-tests-without-change step.

[Jonathan Bedard]

Pull request: https://github.com/WebKit/WebKit/pull/27588

[Jonathan Bedard]

Issue is that patches are now applied as commits, and UnApplyPatch specifically doesn't undo any commit, it just cleans up the working directory.

[Jonathan Bedard]

Created attachment 471044 [details]
Patch

[Jonathan Bedard]

https://ews-build.webkit-uat.org/#/builders/4/builds/27603 is an example of this change working.

[EWS]

Committed 277871@main (2d6113b20845): <https://commits.webkit.org/277871@main>

Reviewed commits have been landed. Closing PR #27588 and removing active labels.