Bug 27286 - Inspector: Keyboard Shortcuts to Switch Panels
Summary: Inspector: Keyboard Shortcuts to Switch Panels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 18:29 PDT by Joseph Pecoraro
Modified: 2009-07-25 14:35 PDT (History)
1 user (show)

See Also:


Attachments
Keyboard Shortcuts for Switching Panels (2.89 KB, patch)
2009-07-14 18:48 PDT, Joseph Pecoraro
timothy: review-
Details | Formatted Diff | Diff
Keyboard Shortcuts for Switching Panels (2.84 KB, patch)
2009-07-23 13:54 PDT, Joseph Pecoraro
kmccullough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2009-07-14 18:29:53 PDT
It would be nice to flip between Web Inspector Panels with keyboard shortcuts.  They are much like tabs in the browser.
Comment 1 Joseph Pecoraro 2009-07-14 18:48:01 PDT
Created attachment 32758 [details]
Keyboard Shortcuts for Switching Panels

Some of the more obvious keyboard shortcuts are taken by Safari.  Like ⌘1, ⌘2, etc. are hot links to bookmarks and Safari grabs them.  It also seems to grab ⇧⌘[ and ⇧⌘] probably because it thinks an undocked Inspector is a window.

So I resorted to ⌘] and ⌘[ for Macs.
I don't actually have a Windows Safari setup but I did ^[ and ^].

Let me know if you can think of other keyboard shortcuts for any features or better ones for panel manipulation.
Comment 2 Timothy Hatcher 2009-07-23 11:40:21 PDT
Comment on attachment 32758 [details]
Keyboard Shortcuts for Switching Panels

> +                    index = (index === 0) ? this.panelOrder.length-1 : index-1;

Should have spaces around the "-"s.
Comment 3 Joseph Pecoraro 2009-07-23 13:54:43 PDT
Created attachment 33368 [details]
Keyboard Shortcuts for Switching Panels

Fix based on review.
Comment 4 Joseph Pecoraro 2009-07-23 13:56:05 PDT
(In reply to comment #2)
> Should have spaces around the "-"s.

Done.
Comment 5 Adam Barth 2009-07-25 14:35:01 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r46397
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
r46397 = 1c431f0eb9ac3e3fdcb5cae52a97bf531525a6b7 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46397