Bug 27284 – HTMLMediaElement::supportsFullscreen() should return false

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pierre d'Herbemont]

But we should let HTMLMediaElement::supportsFullscreen() returns false, and be eventually overridden by the HTMLVideoElement.

[Pierre d'Herbemont]

This was introduced by r45875.

[Pierre d'Herbemont]

Created attachment 32764 [details]
2009-07-14  Pierre d'Herbemont  <[e-mail]>


        Reviewed by NOBODY (OOPS!).

        HTMLMediaElement::supportsFullscreen() should return false
        https://bugs.webkit.org/show_bug.cgi?id=27284

        (Reverting a part of 45875)

        HTMLVideoElement::supportsFullscreen() will properly do the
        job to check if the backend supports fullscreen.

        HTMLVideoElement is the only subclass to support fullscreen
        (conditionnaly). HTMLAudioElement fullscreen is not supported
        and is a different kind of fullscreen, if it comes to be wanted.

        No test can be done currently given that none of the backend
        supports fullscreen.

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::supportsFullscreen):
---
 3 files changed, 26 insertions(+), 7 deletions(-)

[Oliver Hunt]

Comment on attachment 32764 [details]
2009-07-14  Pierre d'Herbemont  <[e-mail]>

r=me

[Pierre d'Herbemont]

r45894