Bug 27284 - HTMLMediaElement::supportsFullscreen() should return false
Summary: HTMLMediaElement::supportsFullscreen() should return false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Pierre d'Herbemont
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 18:04 PDT by Pierre d'Herbemont
Modified: 2009-07-14 22:41 PDT (History)
0 users

See Also:


Attachments
2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com> (2.07 KB, patch)
2009-07-14 20:30 PDT, Pierre d'Herbemont
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre d'Herbemont 2009-07-14 18:04:18 PDT
But we should let HTMLMediaElement::supportsFullscreen() returns false, and be eventually overridden by the HTMLVideoElement.
Comment 1 Pierre d'Herbemont 2009-07-14 20:21:53 PDT
This was introduced by r45875.
Comment 2 Pierre d'Herbemont 2009-07-14 20:30:20 PDT
Created attachment 32764 [details]
2009-07-14  Pierre d'Herbemont  <pdherbemont@apple.com>


        Reviewed by NOBODY (OOPS!).

        HTMLMediaElement::supportsFullscreen() should return false
        https://bugs.webkit.org/show_bug.cgi?id=27284

        (Reverting a part of 45875)

        HTMLVideoElement::supportsFullscreen() will properly do the
        job to check if the backend supports fullscreen.

        HTMLVideoElement is the only subclass to support fullscreen
        (conditionnaly). HTMLAudioElement fullscreen is not supported
        and is a different kind of fullscreen, if it comes to be wanted.

        No test can be done currently given that none of the backend
        supports fullscreen.

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::supportsFullscreen):
---
 3 files changed, 26 insertions(+), 7 deletions(-)
Comment 3 Oliver Hunt 2009-07-14 22:22:17 PDT
Comment on attachment 32764 [details]
2009-07-14  Pierre d'Herbemont  <pdherbemont@apple.com>

r=me
Comment 4 Pierre d'Herbemont 2009-07-14 22:41:02 PDT
r45894