WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
272830
[WPE] Variable length array build warning
https://bugs.webkit.org/show_bug.cgi?id=272830
Summary
[WPE] Variable length array build warning
Philippe Normand
Reported
2024-04-17 10:23:13 PDT
WPEDRMCursor.cpp:72:27: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension] 72 | uint32_t deviceBuffer[m_deviceWidth * m_deviceHeight];
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2024-04-17 11:01:55 PDT
VLAs are stack overflow risks. Use a Vector or something similar instead.
Philippe Normand
Comment 2
2024-04-17 11:05:01 PDT
Yes I have a patch... just waiting the build to... finish.
Philippe Normand
Comment 3
2024-04-17 11:07:58 PDT
Same issue in WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:369 btw.
Philippe Normand
Comment 4
2024-04-17 11:33:29 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/27399
EWS
Comment 5
2024-04-18 08:23:58 PDT
Committed
277675@main
(72ef47e183a4): <
https://commits.webkit.org/277675@main
> Reviewed commits have been landed. Closing PR #27399 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug