Bug 27282 - [V8] Cleanup exception handling in worker evaluation code.
: [V8] Cleanup exception handling in worker evaluation code.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Jian Li
:
Depends on: 25151
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-14 17:30 PDT by Jian Li
Modified: 2009-07-24 11:03 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (6.66 KB, patch)
2009-07-14 17:37 PDT, Jian Li
no flags Details | Formatted Diff | Diff
Proposed Patch (6.06 KB, patch)
2009-07-20 15:27 PDT, Jian Li
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-07-14 17:30:20 PDT
Implement the corresponding V8 changes to deal with the problem that workers with syntax errors not firing error event.
Comment 1 Jian Li 2009-07-14 17:37:42 PDT
Created attachment 32752 [details]
Proposed Patch
Comment 2 Jian Li 2009-07-20 15:27:37 PDT
Created attachment 33115 [details]
Proposed Patch
Comment 3 Adam Barth 2009-07-23 23:09:03 PDT
Comment on attachment 33115 [details]
Proposed Patch

This looks good.  Is there any behavior change we can test?
Comment 4 Jian Li 2009-07-24 09:59:31 PDT
(In reply to comment #3)
> (From update of attachment 33115 [details])
> This looks good.  Is there any behavior change we can test?

The tests are in worker-constructor.html (see patch for bug 27525). This layout test worker-constructor.html will be re-enabled in Chrome until all WebKit patches are landed.
Comment 5 Jian Li 2009-07-24 11:03:01 PDT
Committed as http://trac.webkit.org/changeset/46365