Bug 27281 – Fails to save document state when navigating away from a page with a reference fragment

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[Darin Fisher (:fishd, Google)]

Created attachment 32746 [details]
testcase

Fails to save document state when navigating away from a page
with a reference fragment

Note: This only impacts WebKit when the page also has an unload
handler causing the page cache to be suppressed.

See the attached testcase, but roughly here's the repro steps:

1- Load an HTML page with empty input field
2- Load the same URL, but add a reference fragment to the URL
3- Type in the input field
4- Navigate to another host
5- Navigate back

The values you typed in the input field should be restored, but
if the page had an unload handler, then the values will not be
restored.

The bug is with HistoryItem::isCurrentDocument.  I believe that
it should be using equalIgnoringRef instead of operator== to
compare URLs.

[Darin Fisher (:fishd, Google)]

Patch coming up...

[Darin Fisher (:fishd, Google)]

Created attachment 32748 [details]
v1 patch

Simple patch.  Use equalIgnoringRef to compare the HistoryItem's URL the URL of a document.

[Darin Adler]

Comment on attachment 32748 [details]
v1 patch

> -    return urlString() == doc->url();
> +    return equalIgnoringRef(KURL(urlString()), doc->url());

I would write url() instead of KURL(urlString()).

r=me

[Darin Fisher (:fishd, Google)]

> I would write url() instead of KURL(urlString()).
> 
> r=me

Oh, good catch.  I forgot about that accessor.  Thanks!

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/45890