RESOLVED FIXED 272758
List style changes should be treated as StyleDifference::Layout in RenderListMarker::styleDidChange 
https://bugs.webkit.org/show_bug.cgi?id=272758
Summary List style changes should be treated as StyleDifference::Layout in RenderList...
zalan
Reported 2024-04-16 08:06:56 PDT
ssia
Attachments
Patch (1.96 KB, patch)
2024-04-16 08:10 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2024-04-16 08:46 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2024-04-16 09:50 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (1.96 KB, patch)
2024-04-16 15:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2024-04-16 08:10:28 PDT
Created attachment 470938 [details] Patch
zalan
Comment 2 2024-04-16 08:46:45 PDT
Created attachment 470939 [details] Patch
Antti Koivisto
Comment 3 2024-04-16 08:52:01 PDT
Comment on attachment 470939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=470939&action=review > Source/WebCore/rendering/RenderListMarker.cpp:75 > + if (oldStyle && diff < StyleDifference::Layout) > + diff = !style().isDisplayInlineType() && oldStyle->isDisplayInlineType() ? StyleDifference::Layout : diff; maybe this can be in RenderStyle::diff too?
zalan
Comment 4 2024-04-16 09:50:57 PDT
Created attachment 470940 [details] Patch
zalan
Comment 5 2024-04-16 15:34:55 PDT
Created attachment 470947 [details] [fast-cq]Patch
EWS
Comment 6 2024-04-16 18:42:58 PDT
Committed 277587@main (c74cf588489a): <https://commits.webkit.org/277587@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470947 [details].
Radar WebKit Bug Importer
Comment 7 2024-04-16 18:43:15 PDT
<rdar://problem/126595097>
Note You need to log in before you can comment on or make changes to this bug.