Bug 27271 - [V8] Fix isolated world wrappers for Nodes
Summary: [V8] Fix isolated world wrappers for Nodes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2009-07-14 12:26 PDT by Adam Barth
Modified: 2009-07-14 16:37 PDT (History)
2 users (show)

See Also:

patch (2.64 KB, patch)
2009-07-14 12:34 PDT, Adam Barth
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-07-14 12:26:45 PDT
We're getting the wrong wrappers for nodes because the DOMMap is stored on V8Proxy, subverting the branch in V8DOMMap.cpp.  Patch forthcoming.
Comment 1 Adam Barth 2009-07-14 12:34:15 PDT
Created attachment 32728 [details]

By the way, you can see the test suite I'm working from here:


Once I get these tests in reasonable shape, I can turn on the feature and land the tests.
Comment 2 Dimitri Glazkov (Google) 2009-07-14 12:37:10 PDT
Comment on attachment 32728 [details]

Fix _and_ prettify. I like it.
Comment 3 Adam Barth 2009-07-14 12:44:41 PDT
Thanks.  I'm working on a bunch of related changes in a git branch.  I'll try to land them roughly together.
Comment 4 Adam Barth 2009-07-14 16:37:42 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/V8DOMWrapper.cpp
Sending        WebCore/bindings/v8/V8Proxy.h
Transmitting file data ...
Committed revision 45882.